Hi again!

....Continuing from my previous post. Since it spawned such a good
conversation :)  I can't figure out how I can add a loop counter to my
checking for an empty folder (which BTW I already had in my original code)

In the example below you will see what I am trying to do unsuccessfully.

For /l %%x in (1,1,10) do (
    For /d %%i in (\\%1\%3\%4) do (
        if exist %%i\*.xml goto :copy
        )
    choice /c YN /t 5 /d N /m "Do you want to stop processing of this
batch?"
    set /a Count+=1
    echo %Count% times
)

Show quote Hide quote Try this:
@echo off
setlocal EnableDelayedExpansion
set count=0
For /l %%x in (1,1,10) do (
    For /d %%i in (\\%1\%3\%4) do (
        if exist %%i\*.xml goto :copy
        )
    choice /c YN /t 5 /d N /m "Do you want to stop processing of this
batch?"
    set /a Count+=1
    echo !Count! times
)
Your script has two problems:
- You never initialise the %count% variable. Sometimes you can get away with
this, sometimes you can't.
- All environmental variables inside the "For" loop are scanned and resolved
exactly once: When the whole "For" construct, up to the closing bracket, is
read by the command processor. If your code changes them on the fly then you
must force a rescan, which you do with the "EnableDelayedExpansion" and the
use of exclamation marks around your variables.

By the way - is it your intention to ask the same question ten times?

I actually do have this defined, missed the line when I posted.

I did ty the !count! variable before but it didn't work for me.  Once I
added the EnableDelayedExpansion it did - Never put the two together before
so thank you for that.

Well, I haven't come up with a better way yet to give the option of stopping
the batch file.  You see I'm waiting for a file or folder to show up at
which time I want to move it to a different location.  I don't know the
filename or the foldername and I don't know exactly when the either will
show up so I am looping for up to 2 hours before I consider the file a no
show and error out of the script and send a message.

Show quote Hide quote There is, of course, more than one way to skin this particular cat. Instead
of using a batch file and the legacy "ask" utility, you could use a VB
Script solution and get a nice GUI interface thrown in free of charge. Have
a look at this one:
01. Set oFSO = CreateObject("Scripting.FileSystemObject")
02. Set oArgs = WScript.Arguments
03. Set oShell = WScript.CreateObject("WScript.Shell")
04. sSource = Replace(oArgs(0) & "\", "\\", "\")
05. sTarget = Replace(oArgs(1) & "\", "\\", "\")
06.
07. Const iWait = 120 'minutes
08.
09. dEndTime = DateAdd("n", Now(), iWait)
10. On Error Resume Next
11. Do
12.  i = oFSO.CopyFile(sSource & "*.xml", sTarget)
13.  If Err.number = 0 then Exit Do
14.  If oShell.Popup("Continue waiting?", 10, "Copy Process", 4) = 7 _
15.  Then WScript.Quit
16.  if now() > dEndTime then wscript.quit
17. Loop
18. On Error Goto 0

The script will do this:
- Copy all .xml files from the source to the target, then exit.
- If it cannot find any .xml files then it will display a pop-up
   panel for 10 seconds, giving the user an opportunity to bail out.
- After 10 seconds it tries another copy process.
- After 120 minutes it gives up.
Adding an EMail function would be a trivial process.

To run the script, save the code to c:\VBSCopy.vbs, then remove
the line numbers. Now start a Command Prompt and invoke it like so:

cscript //nologo c:\VBSCopy.vbs "\\Server\Share\Folder" "d:\Target Folder"

I was under the impression VBS wasn't very good for moving network files
around and that I should use WMI to do it instead which is why I went to a
bat file to begin with.  I haven't tried this script yet, but what will be
the affect if I change the target to be another UNC name and if I change the
FSO.CopyFile toFSO.MoveFile?

Show quote Hide quote Your impression is incorrect. The File System Object can handle networked
files as easily as local files. Why don't you give it a try to make sure?

Hi Pegasus,

I tried your script but unfortunately it doesn't work.  I recive the Copy
Process dialog box to continue or not but answering yes or no makes no
difference to the outcome and the XML file(s) are not copied.

My command line is:
cscript VBSCopy.vbs //nologo \\server1\out$ \\server2\archive$

Show quote Hide quote Since the code worked when I tested it, I have to respond with my standard
reply in such cases: Please post the VB code you use.

Here you go.

Set oFSO = CreateObject("Scripting.FileSystemObject")
Set oArgs = WScript.Arguments
Set oShell = WScript.CreateObject("WScript.Shell")
sSource = Replace(oArgs(0) & "\", "\\", "\")
sTarget = Replace(oArgs(1) & "\", "\\", "\")

Const iWait = 1 'minutes

dEndTime = DateAdd("n", Now(), iWait)
On Error Resume Next
Do
i = oFSO.CopyFile(sSource & "*.xml", sTarget)
if Err.number = 0 then Exit Do
If oShell.Popup("Continue waiting?", 10, "Copy Process", 4) = 7 _
Then WScript.Quit
if now() > dEndTime then wscript.quit
Loop
On Error Goto 0

Show quote Hide quote What you report shakes the very foundations of VB Scripting. You claim that
it makes no difference whether you click "Yes" or "No" in thedialog box -
let's put it to the test!

Set oShell = WScript.CreateObject("WScript.Shell")
x = oShell.Popup("Continue waiting?", 10, "Copy Process", 4)
MsgBox "Return code is " & x

Do this:
- Paste the above code into c:\Test.vbs.
- Execute the code the same way as you did before.
- Post the return codes you see.

By the way: The command line you used is not really robust. Instead of
running

cscript VBSCopy.vbs //nologo \\server1\out$ \\server2\archive$
you should run this:
cscript c:\VBSCopy.vbs //nologo \\server1\out$ \\server2\archive$

If you omit the drive and folder information then you might be executing any
program and possibly not the one you think you're running!

Sorry, I don't mean to shake anything... :)  and I do appologize for not
being more detailed in my explaination.
When I said "it makes no difference" I was referring to the fact that the
XML file is not copied to the destination whether I click on "Yes" or "No"
or let it time out.

Clicking yes returns code 6, clicking no returns code 7 and not clicking on
anything returns -1

You previously wrote "I recive the Copy Process dialog box to continue or
not but answering yes or no makes no difference to the outcome". From your
new reply I gather that this is not correct: When you click the "No" button
it does make a difference - the script ends immediately. The VB Script
foundations appear to be intact . . .

This allows us to concentrate on the failure to copy files. My original
script did things "on the cheap": It attempted to copy *.xml files until it
would find some but only for a fixed period of time. To allow the script to
continue if no files were found, I suppressed all possible error messages.
This is not the most elegant way of doing things and it promptly tripped you
up. Here is a more robust way of doing things. It will show you all error
that occur.

Set oFSO = CreateObject("Scripting.FileSystemObject")
Set oArgs = WScript.Arguments
Set oShell = WScript.CreateObject("WScript.Shell")
sSource = Replace(oArgs(0) & "\", "\\", "\")
sTarget = Replace(oArgs(1) & "\", "\\", "\")

LF = Chr(10)
Const iWait = 1 'minutes
dEndTime = DateAdd("n", iWait, Now())

On Error Resume Next
If Not oFSO.FolderExists(sTarget) then oFSO.CreateFolder(sTarget)
If Err > 0 Then
MsgBox "Problem creating the folder """ & sTarget _
  & """" & LF & Err.Description
WScript.Quit
End If
On Error Goto 0

Do
bFound = False
WScript.Echo "Checking for the existence of .xml files . . ."
For Each oFile In oFSO.GetFolder(sSource).Files
  If ucase(right(oFile.Name, 4)) = ".XML" then bFound = True
Next

If bFound Then
  On Error Resume Next
  oFSO.CopyFile sSource & "*.xml", sTarget
  If Err > 0 Then MsgBox "Problem copying files:" _
   & LF & Err.Description
   On Error Goto 0
  WScript.Quit
End If

If Now() > dEndTime _
Then If oShell.Popup("Continue waiting?", 10, "Copy Process", 4) = 7 _
Then WScript.quit
WScript.Sleep 20000
Loop




Show quoteHide quote

xcopy errorlevel problem in script
File monitoring
This script doesn't work i don't know why
Special batchfile
Re: lastLogonTimestamp not set!
Help with VBscript
powershell storage management
Stored Passwords in Internet Explorer
How to run a script by a domain user ?
Copying Files from Client PC to Server